Review main Merged

96119[BUGFIX] Unwrap Extbase request for error page

Wolfgang Klinger CR +2 V +2 Easy +46 −1 updated 10/10/26, 06:27

Commit message

An Extbase action that answers with a 404 page passes its own
$this->request to ErrorController::pageNotFoundAction().
PageContentErrorHandler creates the sub-request for the error page
from this request, so the sub-request is still an Extbase request
with the "extbase" attribute of the plugin. The error page is then
rendered in the context of the plugin, and FLUIDTEMPLATE uses the
template of the plugin instead of the page template.

The "extbase" attribute is now removed from the sub-request. For an
Extbase request, this also returns the plain request it wraps.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1417

  1. Wolfgang Klinger uploaded patch set 1 09/28/26, 05:42

  2. core-ci voted on patch set 1 V +1 09/28/26, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109392

  3. Oliver Klee voted on patch set 1 V +1 09/28/26, 08:11

  4. Rémy DANIEL voted on patch set 1 CR +1 V +1 09/28/26, 09:21

  5. Georg Ringer voted on patch set 1 CR +1 V +1 09/28/26, 19:24

  6. Wouter Wolters voted on patch set 1 CR +1 09/28/26, 20:03

  7. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/28/26, 23:23

  8. Benni Mack updated the commit message in patch set 2 CR +1 V +1 10/09/26, 19:25

  9. Benni Mack voted on patch set 2 CR +1 V +1 10/09/26, 19:25

  10. Georg Ringer voted on patch set 2 CR +2 V +2 10/09/26, 19:30

  11. core-ci voted on patch set 2 V -1 10/09/26, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110700

  12. Benni Mack rebased onto patch set 3 CR +1 V +1 10/09/26, 19:36

  13. Benni Mack voted on patch set 3 CR +1 V +1 10/09/26, 19:38

  14. core-ci voted on patch set 3 V +1 10/09/26, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110705

  15. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/09/26, 19:49

  16. Georg Ringer voted on patch set 3 CR +2 V +2 10/10/26, 06:27

  17. Georg Ringer merged patch set 4 10/10/26, 06:27