96125[FEATURE] Add PSR-14 event after a record is rendered
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Josua Vogel +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Josua Vogel +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110815-AfterRecordIsRenderedEvent.rstnew+86 −0
- typo3/sysext/frontend/Classes/ContentObject/Event/AfterRecordIsRenderedEvent.php4new+58 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+20 −1
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+25 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/Fixtures/AfterRecordIsRendered.csvnew+7 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentContentObjectTest.php+82 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/RecordsContentObjectTest.phpnew+73 −0
Review log 2232
Show 47 earlier messages
-
Oli Bartsch uploaded patch set 1 09/28/26, 12:19
-
core-ci voted on patch set 1 V +1 09/28/26, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109419
-
Oli Bartsch updated the commit message in patch set 2
V +109/28/26, 12:41 -
core-ci voted on patch set 2 V +1 09/28/26, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109420
-
Josua Vogel voted on patch set 2 CR +1 09/28/26, 14:39
-
Oli Bartsch rebased onto patch set 3
CR +1V +109/28/26, 21:03 -
core-ci voted on patch set 3 V -1 09/28/26, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109458
-
Oli Bartsch rebased onto patch set 4
V -109/28/26, 21:25 -
core-ci voted on patch set 4 V +1 09/28/26, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109464
-
Oli Bartsch uploaded patch set 5 09/28/26, 21:51
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
Georg Ringer voted on patch set 5 CR +1 V +1 09/28/26, 21:55
-
core-ci voted on patch set 5 V +1 09/28/26, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109466
-
Josua Vogel voted on patch set 5 CR +1 V +1 09/29/26, 05:02
-
Benni Mack commented on patch set 5 CR -1 09/29/26, 05:18
how would we ensure that this also applies to content that is generated via FLUID? Couldn't we apply this to a Record object or the original array instead, so we don't have to deal with one huge string of content, but with the actual fields?AfterRecordIsRenderedEvent.php:32we could hand in a Record object? -
Oli Bartsch uploaded patch set 6
CR +1V +109/29/26, 07:03 -
Oli Bartsch commented on patch set 6 09/29/26, 07:07
Reply
I don't quite get what you mean by generated via Fluid. Fluid rendering via f:render.record / f:render.contentArea is covered by ModifyRenderedRecordEvent (the related workspace patch listens to both). This event just closes the gap for CONTENT/RECORDS. Records printed inline in templates have no render boundary, so no event can cover them. Field-level processing doesn't work for the marker use case, since we need to know where a record's output starts and ends, and values injected into fields get escaped/cropped/parsed.AfterRecordIsRenderedEvent.php:32ReplyDone. getRecord() now returns a RecordInterface, like ModifyRenderedRecordEvent. It is resolved on first access, so rows no listener asks for cost nothing. It can't be created eagerly: RecordFactory throws for rows without the type field, e.g. CONTENT with a custom select.selectFields = uid, header, and that would break existing TypoScript. So getRecord() is nullable and never throws, and the raw row is still there via getRow(), including workspace / language overlay fields. -
core-ci voted on patch set 6 V +1 09/29/26, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109483
-
Benni Mack commented on patch set 6 09/30/26, 21:39
Reply
ModifyRenderedRecordEvent worksAfterRecordIsRenderedEvent.php:32Replysounds good. Should we also add a request, or something like this? Or lets put it the other way: Do we need cObj, or could we instead hand over "request"? -
Oli Bartsch uploaded patch set 7
V +109/30/26, 21:51 -
Oli Bartsch commented on patch set 7 09/30/26, 21:52
AfterRecordIsRenderedEvent.php:32ReplyDone -
core-ci voted on patch set 7 V -1 09/30/26, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109725
-
Oli Bartsch rebased onto patch set 8
V -110/01/26, 06:00 -
core-ci voted on patch set 8 V +1 10/01/26, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109747
-
Oli Bartsch uploaded patch set 9
V +110/01/26, 07:55 -
Benni Mack voted on patch set 9 CR +1 V +1 10/01/26, 07:59
-
core-ci voted on patch set 9 V -1 10/01/26, 08:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109762
-
Oli Bartsch uploaded patch set 10
CR +1V +110/01/26, 08:20 -
Benni Mack voted on patch set 10 CR +1 V +1 10/01/26, 08:24
-
Josua Vogel voted on patch set 10 CR +1 V +1 10/01/26, 08:25
-
core-ci voted on patch set 10 V +1 10/01/26, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109767
-
Oli Bartsch voted on patch set 10 CR +2 V +2 10/01/26, 08:32
-
Oli Bartsch merged patch set 11 10/01/26, 08:32