Review main Merged

96139[BUGFIX] Detect non-null scanner arguments

Wouter Wolters CR +2 V +2 Normal +55 −32 updated 09/29/26, 06:29

Commit message

The extension scanner skips all constant values in unused argument
positions, although only null is allowed there. Report other constants
in method and constructor calls.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 610

  1. Wouter Wolters uploaded patch set 1 09/28/26, 19:57

  2. Wouter Wolters uploaded patch set 2 09/28/26, 19:59

  3. core-ci voted on patch set 1 V -1 09/28/26, 20:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109449

  4. core-ci voted on patch set 2 V -1 09/28/26, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109450

  5. core-ci commented on patch set 2 09/28/26, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109450

  6. Wouter Wolters rebased onto patch set 3 V -1 09/28/26, 21:19

  7. core-ci voted on patch set 3 V +1 09/28/26, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109461

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/28/26, 23:19

  9. Benni Mack voted on patch set 3 CR +2 V +2 09/29/26, 06:29

  10. Benni Mack merged patch set 4 09/29/26, 06:29