Review main Merged

96141[TASK] Remove redundant collection type check

Wouter Wolters CR +2 V +2 Easy +1 −7 updated 09/30/26, 06:23

Commit message

The array check runs only after the value is known to be an object.
Remove it and the corresponding PHPStan baseline entry without changing
validation behavior.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Sebastian Iffland +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Wouter Wolters uploaded patch set 1 09/28/26, 20:11

  2. Oliver Klee voted on patch set 1 CR +1 V +1 09/28/26, 20:16

  3. core-ci voted on patch set 1 V -1 09/28/26, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109453

  4. Oliver Klee voted on patch set 1 CR 0 V 0 09/28/26, 20:23

  5. core-ci commented on patch set 1 09/28/26, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109453

  6. Wouter Wolters rebased onto patch set 2 V -1 09/28/26, 21:19

  7. core-ci voted on patch set 2 V +1 09/28/26, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109462

  8. Oliver Klee voted on patch set 2 CR +1 V +1 09/28/26, 21:49

  9. Sebastian Iffland voted on patch set 2 CR +1 09/30/26, 06:19

  10. Benni Mack voted on patch set 2 CR +2 V +2 09/30/26, 06:23

  11. Benni Mack merged patch set 3 09/30/26, 06:23