Review main Abandoned

96143[BUGFIX] Report native field validation errors in FormEngine

Georg Ringer CR 0 V 0 Normal +45 −6 updated 11/11/26, 12:41

Commit message

Since FormEngine saves via `requestSubmit()`, the browser's
constraint validation runs before any submit handler. A field
with a natively invalid value, e.g. an invalid address in a
`type="email"` input, silently blocked saving if it was placed
in an inactive tab, as the browser cannot focus it.

FormEngine validation now takes the native validity state of a
field into account, so the field, its label and its tab are
marked as erroneous. The `invalid` event of such fields is
intercepted to show the FormEngine error modal instead.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 4

Review log 915

  1. Georg Ringer uploaded patch set 1 09/28/26, 22:06

  2. Georg Ringer commented on patch set 1 09/28/26, 22:07

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/28/26, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109468

  4. Sebastian Klein voted on patch set 1 CR +1 V +1 09/30/26, 13:57

  5. Georg Ringer uploaded patch set 2 CR +1 V +1 11/10/26, 18:27

  6. core-ci voted on patch set 2 V -1 11/10/26, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113934

  7. Georg Ringer uploaded patch set 3 V -1 11/10/26, 18:59

  8. core-ci voted on patch set 3 V +1 11/10/26, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113940

  9. Benni Mack updated the commit message in patch set 4 V +1 11/11/26, 10:00

  10. Benni Mack rebased onto patch set 5 11/11/26, 10:00

  11. Benni Mack updated the commit message in patch set 6 11/11/26, 10:04

  12. core-ci voted on patch set 5 V +1 11/11/26, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114040

  13. core-ci voted on patch set 6 V +1 11/11/26, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114042

  14. core-ci voted on patch set 4 V +1 11/11/26, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114039

  15. Benni Mack abandoned the change 11/11/26, 12:41