Review main Merged

96154[BUGFIX] Write history for fields DataHandler makes unique

Oli Bartsch CR +2 V +2 Normal +109 −6 updated 10/02/26, 12:11

Commit message

When a move makes DataHandler change a slug or another unique field,
for example of subpages moved into another site, the change was not
written to sys_history. The record history could therefore not roll
the move back completely, and subpages kept their changed slugs.

The previous value is known at that point, so the change is now
recorded as part of the move, which also resolves the @todo in
fixUniqueInSiteForSubpages().

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Oli Bartsch uploaded patch set 1 09/29/26, 07:11

  2. core-ci voted on patch set 1 V +1 09/29/26, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109485

  3. Benni Mack commented on patch set 1 09/30/26, 21:34

    this looks good in general, however I need to check if this actually creates 2 entries in history
  4. Oli Bartsch commented on patch set 1 10/02/26, 07:31

    Reply

    Can you check :)
  5. Benni Mack uploaded patch set 2 V +1 10/02/26, 10:57

  6. Benni Mack commented on patch set 2 CR +1 V +1 10/02/26, 10:58

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 10/02/26, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109918

  8. Georg Ringer voted on patch set 2 CR +1 V +1 10/02/26, 11:23

  9. Oli Bartsch voted on patch set 2 CR +2 V +2 10/02/26, 12:11

  10. Oli Bartsch merged patch set 3 10/02/26, 12:11