Review main Merged

96155[BUGFIX] Make notification actions work and wait for the user

Oli Bartsch CR +2 V +2 Hard +271 −6 updated 10/07/26, 20:20

Commit message

The click handler of a notification action read event.currentTarget
after an await, when it is null already. A DeferredAction therefore
failed before its callback ran, the revert of a slug change in
EXT:redirects for example. An executing action also ran again when
activated by keyboard, as the links only ignore the pointer.

Notifications disappeared after their duration even while pointed
at, focused or while an action was executing, so their actions could
hardly be reached by keyboard (WCAG 2.2.1). A notification shown
while a modal closed, as the move wizards do, was even removed along
with the modal right away.

The link is now taken before the await, and an executing action
ignores further activations. The countdown pauses while the
notification is pointed at or focused, and continues with the time
that was left. The list announces new notifications to assistive
technology, and leaves a closing modal before it is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 813

  1. Oli Bartsch uploaded patch set 1 09/29/26, 07:17

  2. core-ci voted on patch set 1 V +1 09/29/26, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109486

  3. Oli Bartsch rebased onto patch set 2 V +1 10/01/26, 06:04

  4. core-ci voted on patch set 2 V +1 10/01/26, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109750

  5. Oli Bartsch rebased onto patch set 3 V +1 10/02/26, 12:50

  6. core-ci voted on patch set 3 V +1 10/02/26, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109937

  7. Oli Bartsch uploaded patch set 4 V +1 10/02/26, 15:31

  8. core-ci voted on patch set 4 V +1 10/02/26, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109962

  9. Oli Bartsch uploaded patch set 5 V +1 10/05/26, 15:02

  10. core-ci voted on patch set 5 V +1 10/05/26, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110123

  11. Benni Mack voted on patch set 5 CR +1 V +1 10/07/26, 14:27

  12. Oli Bartsch voted on patch set 5 CR +2 V +2 10/07/26, 20:20

  13. Oli Bartsch merged patch set 6 10/07/26, 20:20