Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96159[TASK] Use short translation domain syntax in EXT:workspaces
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/59/96159/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/59/96159/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Oli Bartsch +1
- Benni Mack -1
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Oli Bartsch +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 42
- Build/Sources/TypeScript/workspaces/element/workspace-selector-element.ts+1 −1
- Build/Sources/TypeScript/workspaces/element/workspace-top-indicator-element.ts+1 −1
- Build/Sources/TypeScript/workspaces/renderable/record-information.ts+3 −3
- Build/Sources/TypeScript/workspaces/renderable/record-table.ts+15 −15
- Build/Sources/TypeScript/workspaces/renderable/send-to-stage-form.ts+6 −6
- Build/Sources/TypeScript/workspaces/backend.ts+12 −12
- Build/Sources/TypeScript/workspaces/preview.ts+4 −4
- Build/Sources/TypeScript/workspaces/workspace-state.ts+2 −2
- Build/Sources/TypeScript/workspaces/workspaces.ts+1 −1
- typo3/sysext/backend/Classes/Template/Components/AbstractControl.php+2 −2
- typo3/sysext/workspaces/Classes/Backend/LiveSearch/WorkspaceProvider.php+2 −2
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+5 −5
- typo3/sysext/workspaces/Classes/Controller/WorkspacesAjaxController.php+9 −9
- typo3/sysext/workspaces/Classes/Domain/Repository/WorkspaceStageRepository.php+3 −3
- typo3/sysext/workspaces/Classes/EventListener/PageTreeItemsHighlighter.php+3 −3
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php+2 −5
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+5 −7
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+3 −3
- typo3/sysext/workspaces/Classes/Service/IntegrityService.php+2 −2
- typo3/sysext/workspaces/Classes/Service/StagesService.php+4 −4
Show 22 more files
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+4 −4
- typo3/sysext/workspaces/Configuration/TCA/Overrides/be_users.php+1 −1
- typo3/sysext/workspaces/Configuration/TCA/sys_workspace.php+9 −9
- typo3/sysext/workspaces/Configuration/TCA/sys_workspace_stage.php+4 −4
- typo3/sysext/workspaces/Resources/Private/Language/db.xlfrenamed+5 −5
- typo3/sysext/workspaces/Resources/Private/Language/locallang_mod.xlfdeleted+0 −32
- typo3/sysext/workspaces/Resources/Private/Language/messages.xlfrenamed+101 −107
- typo3/sysext/workspaces/Resources/Private/Language/module.xlf+24 −0
- typo3/sysext/workspaces/Resources/Private/Partials/WorkingTable.fluid.html+17 −17
- typo3/sysext/workspaces/Resources/Private/Templates/Preview/Ajax/StageButtons.fluid.html+2 −2
- typo3/sysext/workspaces/Resources/Private/Templates/Preview/Index.fluid.html+7 −7
- typo3/sysext/workspaces/Resources/Private/Templates/Review/Index.fluid.html+5 −5
- typo3/sysext/workspaces/Resources/Public/JavaScript/element/workspace-selector-element.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/element/workspace-top-indicator-element.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-information.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-table.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/send-to-stage-form.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/workspace-state.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/workspaces.js+1 −1
- typo3/sysext/workspaces/Tests/Functional/EventListener/PageTreeItemsHighlighterTest.php+4 −4
Review log 912
-
Benni Mack uploaded patch set 1 09/29/26, 08:51
-
core-ci voted on patch set 1 V +1 09/29/26, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109496
-
Benni Mack rebased onto patch set 2
V +109/29/26, 09:02 -
core-ci voted on patch set 2 V +1 09/29/26, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109497
-
Benni Mack marked it ready for review 09/29/26, 09:28
-
Benni Mack uploaded patch set 3
V +110/07/26, 15:34 -
core-ci voted on patch set 3 V +1 10/07/26, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110366
-
Oli Bartsch commented on patch set 3 10/07/26, 18:01
Did you do this manually or was this assisted by any AI agant? -
Benni Mack commented on patch set 3 10/07/26, 18:43
Reply
I did the work on this manually, then the AI agent spotted some mistakes I made / places I forgot and finished the work. -
Oli Bartsch commented on patch set 3 CR +1 V +1 10/07/26, 21:03
Reply
Ok, thanks for the transparency. -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/08/26, 00:21
-
Benni Mack commented on patch set 3 CR -1 10/08/26, 06:54
waiting for other feedback on the conventions / best practices