Review main Merged

96164[TASK] Correct authentication log parameter types

Wouter Wolters CR +2 V +2 Easy +1 −7 updated 09/30/26, 05:37

Commit message

Document variadic log parameters with the types accepted by vsprintf().
Remove the matching PHPStan baseline entry.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Wouter Wolters uploaded patch set 1 09/29/26, 15:55

  2. core-ci voted on patch set 1 V +1 09/29/26, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109514

  3. Wouter Wolters uploaded patch set 2 V +1 09/29/26, 16:15

  4. core-ci voted on patch set 2 V -1 09/29/26, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109522

  5. Wouter Wolters uploaded patch set 3 V -1 09/29/26, 16:25

  6. core-ci voted on patch set 3 V -1 09/29/26, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109523

  7. Wouter Wolters uploaded patch set 4 V -1 09/29/26, 16:59

  8. core-ci voted on patch set 4 V +1 09/29/26, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109524

  9. Wouter Wolters marked it ready for review 09/29/26, 19:20

  10. Josua Vogel voted on patch set 4 CR +1 V +1 09/29/26, 19:31

  11. Georg Ringer voted on patch set 4 CR +1 V +1 09/29/26, 20:44

  12. Benni Mack voted on patch set 4 CR +2 V +2 09/30/26, 05:37

  13. Benni Mack merged patch set 5 09/30/26, 05:37