Review main Merged

96166[TASK] Remove redundant hidden field class check

Wouter Wolters CR +2 V +2 Easy +1 −7 updated 09/30/26, 08:03

Commit message

The isset() check already excludes null. Remove the redundant comparison
and its PHPStan baseline entry without changing the form output.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Wouter Wolters uploaded patch set 1 09/29/26, 16:02

  2. core-ci voted on patch set 1 V +1 09/29/26, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109516

  3. Wouter Wolters marked it ready for review 09/29/26, 16:12

  4. Josua Vogel voted on patch set 1 CR +1 V +1 09/29/26, 17:15

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 09/30/26, 07:30

  6. Oliver Klee voted on patch set 1 CR +1 V +1 09/30/26, 07:46

  7. Garvin Hicking uploaded patch set 2 CR +1 V +1 09/30/26, 07:48

  8. core-ci voted on patch set 2 V +1 09/30/26, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109592

  9. Josua Vogel voted on patch set 2 CR +1 V +1 09/30/26, 07:58

  10. Garvin Hicking voted on patch set 2 CR +2 V +2 09/30/26, 08:03

  11. Garvin Hicking merged patch set 3 09/30/26, 08:03