Review main Merged

96167[TASK] Remove redundant IN value null check

Wouter Wolters CR +2 V +2 Easy +14 −13 updated 10/10/26, 10:13

Commit message

DataMapper::getPlainValue() cannot return null, and parameter creation
already calls it. Build each parameter once and check the resulting
list for emptiness. Cover the empty-list exception.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1417

  1. Wouter Wolters uploaded patch set 1 09/29/26, 16:04

  2. core-ci voted on patch set 1 V +1 09/29/26, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109517

  3. Wouter Wolters marked it ready for review 09/29/26, 16:21

  4. Stefan Bürk commented on patch set 1 09/29/26, 21:26

    Typo3DbQueryParser.php:391

    Technically this is wrong - databases allow query against an (`IN(NULL)`) .. just not `IN()`). On the otherhand, this uses placeholders per array element, which increases later dbal parsins/splitting again. I wonder if we possibly can avoid the named parameters at all and possible directly use `QueryBuilder->quoteArrayBasedValueListToIntegerList()` or `->quoteArrayBasedValueListToStringList()` if we know to use string or int values (type). Not to block this, but possiblly to investigate for a followup. Alos to investigate if we can avoid the comparison usage here and instead switch to proper expression mathods directly, even for the other cases.
  5. Wouter Wolters commented on patch set 1 09/29/26, 21:33

    Typo3DbQueryParser.php:391 Reply

    I suggest creatin a ticket for this to investigate that further. This change is meant to fix the phpstan error. `createTypedNamedParameter` always returns a string so can never be NULL.
  6. Stefan Bürk commented on patch set 1 CR +1 V +1 09/29/26, 21:34

    Typo3DbQueryParser.php:391 Reply

    Forget it, looking into that on my own.
  7. Wouter Wolters uploaded patch set 2 CR +1 V +1 09/30/26, 10:40

  8. core-ci voted on patch set 2 V +1 09/30/26, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109614

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/30/26, 22:47

  10. Wouter Wolters uploaded patch set 3 CR +1 V +1 10/09/26, 20:13

  11. core-ci voted on patch set 3 V +1 10/09/26, 20:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110710

  12. Benni Mack voted on patch set 3 CR +1 V +1 10/10/26, 06:30

  13. Josua Vogel voted on patch set 3 CR +1 10/10/26, 06:58

  14. Oliver Klee voted on patch set 3 CR +1 V +1 10/10/26, 08:29

  15. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/10/26, 09:01

  16. Benni Mack voted on patch set 3 CR +2 V +2 10/10/26, 10:13

  17. Benni Mack merged patch set 4 10/10/26, 10:13