Review main Merged

96169[TASK] Remove redundant object checks in select ViewHelper

Wouter Wolters CR +2 V +2 Easy +2 −8 updated 09/30/26, 07:35

Commit message

After scalar and array options are handled, the remaining option is an
object. Remove two redundant checks and their PHPStan baseline entry.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Wouter Wolters uploaded patch set 1 09/29/26, 16:08

  2. core-ci voted on patch set 1 V +1 09/29/26, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109519

  3. Wouter Wolters marked it ready for review 09/29/26, 16:20

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/30/26, 07:19

  5. Benni Mack voted on patch set 1 CR +2 V +2 09/30/26, 07:23

  6. Benni Mack merged patch set 2 09/30/26, 07:35