Review main Ready for review Quiet

96172[BUGFIX] Allow saving after removing invalid flex form containers

Georg Ringer CR 0 V 0 Normal +70 −12 updated 09/29/26, 19:07

Commit message

Removing a flex form section container with invalid fields, e.g. a
newly added one with empty required fields, left the record invalid
and prevented saving it.

Several things went wrong on removal:

* The container never got the "t3js-flex-section-deleted" class
  anymore, which FormEngineValidation uses to skip deleted containers.
* The validation state of the fields in the removed container was
  kept, so FormEngineValidation::isValid() still reported errors.
* Hiding the container and triggering the re-validation depended on
  a "transitionend" event, which is not fired anymore as the panel
  styles override the opacity transition of the container.

The container is now marked correctly, its validation errors are
dropped and the re-validation is triggered right away. The container
is hidden once running animations are finished.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/72/96172/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/72/96172/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 2

Issues 2

Files 3

Review log 23

  1. Georg Ringer uploaded patch set 1 09/29/26, 18:54

  2. Georg Ringer commented on patch set 1 09/29/26, 18:54

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/29/26, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109529