Review main Merged

96176[TASK] Make backed enum mapping assertions meaningful

Wouter Wolters CR +2 V +2 Easy +2 −12 updated 09/30/26, 07:17

Commit message

Give each test enum a second case so the expected mapping result is
not implied by its type. Remove the two PHPStan baseline entries.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1

Issues 1

Files 3

Review log 1012

  1. Wouter Wolters uploaded patch set 1 09/29/26, 19:25

  2. core-ci voted on patch set 1 V +1 09/29/26, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109535

  3. Wouter Wolters marked it ready for review 09/29/26, 19:33

  4. Josua Vogel voted on patch set 1 CR +1 V +1 09/29/26, 19:38

  5. Georg Ringer voted on patch set 1 CR +1 V +1 09/29/26, 20:44

  6. Georg Ringer voted on patch set 1 CR +2 V +2 09/30/26, 05:37

  7. Benni Mack voted on patch set 1 CR +1 V +1 09/30/26, 05:47

  8. Georg Ringer uploaded patch set 2 CR +1 V +1 09/30/26, 07:08

  9. Benni Mack voted on patch set 2 CR +1 V +1 09/30/26, 07:10

  10. Georg Ringer voted on patch set 2 CR +2 V +2 09/30/26, 07:12

  11. Georg Ringer merged patch set 3 09/30/26, 07:12

  12. core-ci voted on patch set 2 V +1 09/30/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109582