Review main Merged

96179[BUGFIX] Prevent integer overflow in paginator offset calculation

Georg Ringer CR +2 V +2 Easy +16 −1 updated 09/30/26, 06:23

Commit message

AbstractPaginator calculated the offset from the requested page
number before the page number was clamped to the last page. For a
huge page number, e.g. taken from a request parameter, the
multiplication overflowed to float and casting it to int raised
a warning with PHP 8.5.

The offset is now calculated after the page number has been clamped,
which also makes the int cast obsolete.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Georg Ringer uploaded patch set 1 09/29/26, 19:48

  2. Georg Ringer commented on patch set 1 09/29/26, 19:48

    This change is ready for review.
  3. Wouter Wolters voted on patch set 1 CR +1 V +1 09/29/26, 19:50

  4. core-ci voted on patch set 1 V +1 09/29/26, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109538

  5. Benni Mack voted on patch set 1 CR +1 V +1 09/30/26, 05:49

  6. Georg Ringer voted on patch set 1 CR +2 V +2 09/30/26, 06:23

  7. Georg Ringer merged patch set 2 09/30/26, 06:23