Review main Merged

96180[TASK] Document countable static route mappers

Wouter Wolters CR +2 V +2 Easy +1 −6 updated 09/30/26, 05:57

Commit message

Route::filterAspects() returns aspects that match both requested
interfaces, but its general return type does not express that. Document
the filtered type and remove the matching PHPStan baseline entry.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Wouter Wolters uploaded patch set 1 09/29/26, 19:49

  2. core-ci voted on patch set 1 V +1 09/29/26, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109539

  3. Wouter Wolters marked it ready for review 09/29/26, 20:04

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/29/26, 20:43

  5. Benni Mack voted on patch set 1 CR +2 V +2 09/30/26, 05:57

  6. Benni Mack merged patch set 2 09/30/26, 05:57