Review main Merged

96181[TASK] Document file converter resource classes

Wouter Wolters CR +2 V +2 Easy +4 −6 updated 09/30/26, 07:44

Commit message

Describe the expected core resource classes in the converter so
PHPStan can narrow the value after the type check. Remove the matching
baseline entry.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Wouter Wolters uploaded patch set 1 09/29/26, 20:00

  2. core-ci voted on patch set 1 V +1 09/29/26, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109541

  3. Wouter Wolters marked it ready for review 09/29/26, 20:08

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/29/26, 20:43

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 09/30/26, 06:08

  6. Garvin Hicking uploaded patch set 2 CR +1 V +1 09/30/26, 07:27

  7. core-ci voted on patch set 2 V +1 09/30/26, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109587

  8. Garvin Hicking commented on patch set 2 CR +2 V +2 09/30/26, 07:44

    Just rebased, counting prior votes for merge
  9. Garvin Hicking merged patch set 3 09/30/26, 07:44