Review main Merged

96187[FEATURE] Copy generated passwords to the clipboard

Oli Bartsch CR +2 V +2 Normal +232 −2 updated 10/01/26, 08:31

Commit message

A password generated into a field that may not be edited is shown in a
disabled input, whose text cannot be selected. Once the record is saved
it is hashed and cannot be shown again, so there was no reliable way to
take it along.

TCA type "password" now accepts the new "appearance" option
"enableCopyToClipboard". The element renders a copy button beside the
input, which is hidden until the field holds a plain value. The option
is off by default.

The "secret" field of a reaction enables it.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1214

  1. Oli Bartsch uploaded patch set 1 09/29/26, 21:39

  2. Wouter Wolters voted on patch set 1 CR +1 09/29/26, 21:41

  3. core-ci voted on patch set 1 V +1 09/29/26, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109547

  4. Benni Mack commented on patch set 1 09/30/26, 05:24

    sys_reaction.php:85

    how about moving this to `appearance` => ['copyToClipboard' => true]`?
  5. Wouter Wolters commented on patch set 1 09/30/26, 16:42

    sys_reaction.php:85 Reply

    IMO than we create a difference between how UuidElement has it and here.
  6. Oli Bartsch commented on patch set 1 09/30/26, 20:02

    sys_reaction.php:85 Reply

    Yes that was also my intention, having this consistent with UUID. Maybe the right thing to do would be to have both in `appearance`, but I'm not quite sure if it is worth the effort (TCA Migration, etc.)
  7. Benni Mack commented on patch set 1 09/30/26, 20:56

    sys_reaction.php:85 Reply

    I think we should move the UUID in appearance, because other options are there as well for nearly all other options - but that'd be a separate topic (with migration, which should be easy nowadays thanks to TcaMigration)
  8. Oli Bartsch uploaded patch set 2 CR +1 V +1 09/30/26, 21:19

  9. Wouter Wolters voted on patch set 2 CR +1 V +1 09/30/26, 21:20

  10. core-ci voted on patch set 2 V +1 09/30/26, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109716

  11. Oli Bartsch commented on patch set 2 09/30/26, 21:30

    sys_reaction.php:85 Reply

  12. Benni Mack voted on patch set 2 CR +1 V +1 10/01/26, 07:56

  13. Oli Bartsch voted on patch set 2 CR +2 V +2 10/01/26, 08:31

  14. Oli Bartsch merged patch set 3 10/01/26, 08:31