Review main Abandoned

96205[BUGFIX] Allow submitting the login refresh form with enter

Oli Bartsch CR 0 V 0 Normal +56 −10 updated 09/30/26, 20:23

Commit message

The password form shown after a backend session timeout contains
two text inputs and no submit button, so browsers do not submit it
implicitly when enter is pressed. The enter key is now handled
explicitly on the password field.

Additionally, the "Login" button no longer fires a separate session
refresh request and closes the modal before the login request has
finished. It only submits the form, which already closes the modal
on success and keeps it open with an error notification on failure.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Oli Bartsch uploaded patch set 1 09/30/26, 07:26

  2. core-ci voted on patch set 1 V +1 09/30/26, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109586

  3. Benni Mack commented on patch set 1 09/30/26, 07:52

  4. Oli Bartsch commented on patch set 1 09/30/26, 20:22

    Reply

    Right, 94132 fixes both issues natively and covers more modals. Abandoning this one in favour of it.
  5. Oli Bartsch abandoned the change 09/30/26, 20:23

    In favour of #109864