Review main Merged

96214[BUGFIX] Restrict backend AJAX logout route to POST

Benni Mack CR +2 V +2 Easy +25 −2 updated 09/30/26, 20:31

Commit message

The backend AJAX route "ajax_logout" is public and therefore not
protected by a request token, but it accepted any HTTP method. A
session could thus be terminated by a plain link or image request,
which was only mitigated by the SameSite attribute of the session
cookie.

The route is now limited to POST. The only caller, the relogin
handling after a session timeout, sends a POST request now. The
logout button of the backend uses the separate "logout" route and
is not affected.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Wouter Wolters +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 89

  1. Benni Mack uploaded patch set 1 09/30/26, 11:20

  2. core-ci voted on patch set 1 V +1 09/30/26, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109618

  3. Josua Vogel voted on patch set 1 CR +1 09/30/26, 11:37

  4. Wouter Wolters voted on patch set 1 CR +1 09/30/26, 12:46

  5. Wouter Wolters voted on patch set 1 V +1 09/30/26, 16:09

  6. Oliver Klee voted on patch set 1 CR +1 V +1 09/30/26, 16:23

  7. Georg Ringer voted on patch set 1 CR +1 V +1 09/30/26, 20:30

  8. Benni Mack voted on patch set 1 CR +2 V +2 09/30/26, 20:31

  9. Benni Mack merged patch set 2 09/30/26, 20:31