Review main Merged

96216[FEATURE] Add upgrade:scan console command for the extension scanner

Olivier Dobberkau CR +2 V +2 Expert +1357 −4 updated 10/27/26, 20:56

Commit message

The extension scanner had no console command, so it was unavailable in
CI pipelines, pre-upgrade scripts and other automated workflows.

`vendor/bin/typo3 upgrade:scan` scans all non-core extensions, or the
ones given as arguments, with the same rules as the install tool. It
prints a table, or with `--json` one JSON object that carries the
Core version the rules came from.

Strong findings and files the parser could not read make the exit code
non-zero. `--fail-on=any` includes weak findings, `--fail-on=none`
reports only.

The command supports shell auto-completion (to discover all available
extensions easily), `--indicator=weak/strong/any` filtering and a
verbose table output revealing affecting ReST changelog files.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1421

  1. Olivier Dobberkau uploaded patch set 1 09/30/26, 11:53

  2. core-ci voted on patch set 1 V +1 09/30/26, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109620

  3. Olivier Dobberkau rebased onto patch set 2 V +1 09/30/26, 15:41

  4. core-ci voted on patch set 2 V -1 09/30/26, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109666

  5. Olivier Dobberkau rebased onto patch set 3 V -1 10/01/26, 21:39

  6. Olivier Dobberkau commented on patch set 3 10/01/26, 21:41

    AI-assisted contribution: prepared with Claude Code under my supervision. I reviewed every line of the diff, ran unit, functional, phpstan, cgl and lintPhp locally and take responsibility for this change. Rebased onto patch set 3 of https://review.typo3.org/c/Packages/TYPO3.CMS/+/96215, which fixes the unit test failures that this change inherited.
  7. core-ci voted on patch set 3 V +1 10/01/26, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109847

  8. Olivier Dobberkau uploaded patch set 4 V +1 10/02/26, 07:43

  9. core-ci voted on patch set 4 V +1 10/02/26, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109887

  10. Olivier Dobberkau rebased onto patch set 5 V +1 10/02/26, 12:31

  11. core-ci voted on patch set 5 V +1 10/02/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109934

  12. Garvin Hicking uploaded patch set 6 V +1 10/16/26, 14:21

  13. core-ci voted on patch set 6 V +1 10/16/26, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111367

  14. Garvin Hicking commented on patch set 6 CR +1 V +1 10/16/26, 14:30

    Reply

    Acknowledged
    Thanks for this. I added a few minor things here, please check if these are fine by you :-)
  15. Garvin Hicking uploaded patch set 7 CR +1 V +1 10/27/26, 20:14

    use direct json command like in core
  16. Garvin Hicking commented on patch set 7 10/27/26, 20:16

    @olivier.dobberkau@dkd.de I adjusted the patch after a note from Simon Praetorius to utilize `--json` instead of `--format=json` to align with other core usages. Hope this is fine for you, too!
  17. Garvin Hicking voted on patch set 7 CR +1 V +1 10/27/26, 20:16

  18. core-ci voted on patch set 7 V +1 10/27/26, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112657

  19. Simon Schaufelberger voted on patch set 7 CR +1 V +1 10/27/26, 20:52

  20. Garvin Hicking voted on patch set 7 CR +2 V +2 10/27/26, 20:56

  21. Garvin Hicking merged patch set 8 10/27/26, 20:56