Review 14.3 Merged

96218[TASK] Correct schema migrator selection parameter type

Benni Mack CR +2 V +2 Easy +1 −7 updated 09/30/26, 13:59

Commit message

SchemaMigrator selects statements by hash key. Correct the PHPDoc
array shape and remove the matching PHPStan baseline entry.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 09/30/26, 12:33

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon
  2. Benni Mack commented on patch set 2 09/30/26, 12:34

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 09/30/26, 12:34

  4. core-ci voted on patch set 2 V +1 09/30/26, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109624

  5. core-ci voted on patch set 1 V -1 09/30/26, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109623

  6. Benni Mack voted on patch set 2 CR +2 V +2 09/30/26, 13:59

  7. Benni Mack merged patch set 3 09/30/26, 13:59