Review main Merged

96225[BUGFIX] Keep record language when copying content elements

Benni Mack CR +2 V +2 Normal +78 −1 updated 10/01/26, 08:24

Commit message

The TCA setting "copyAfterDuplFields" of tt_content listed
"sys_language_uid" next to "colPos". When a content element was
copied and pasted after another record, the copy therefore took
over the language of the preceding record instead of keeping its
own. An element set to "All languages" became a German element
when pasted after a German one, and vice versa.

Language is a property of the record, not of its position. A copy
now keeps the language of its source. It only changes if the caller
asks for it explicitly, for example via the update data of a paste
command as sent by the page module, or via the localization
commands.

The setting is reduced to "colPos" and an Important changelog entry
documents the rule.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 4

Files 4

Review log 79

  1. Benni Mack uploaded patch set 1 09/30/26, 15:27

  2. core-ci voted on patch set 1 V -1 09/30/26, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109659

  3. Benni Mack marked it ready for review 09/30/26, 21:14

  4. Benni Mack rebased onto patch set 2 V -1 09/30/26, 21:14

  5. core-ci voted on patch set 2 V +1 09/30/26, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109715

  6. Wouter Wolters voted on patch set 2 CR +1 V +1 09/30/26, 21:26

  7. Oli Bartsch voted on patch set 2 CR +1 V +1 10/01/26, 07:33

  8. Benni Mack voted on patch set 2 CR +2 V +2 10/01/26, 08:24

  9. Benni Mack merged patch set 3 10/01/26, 08:24