96226[TASK] Remove XSL stylesheet support from XML sitemap
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 13
- Build/tests/playwright/e2e/frontend/sitemap.spec.ts+7 −16
- typo3/sysext/core/Documentation/Changelog/15.0/Important-110862-RemovedXslStylesheetFromXmlSitemap.rstnew+38 −0
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php+0 −74
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/setup.typoscript+0 −6
- typo3/sysext/seo/Documentation/Features/XmlSitemap.rst+0 −40
- typo3/sysext/seo/Resources/Private/Templates/XmlSitemap/Index.fluid.xml+1 −1
- typo3/sysext/seo/Resources/Private/Templates/XmlSitemap/Sitemap.fluid.xml+1 −1
- typo3/sysext/seo/Resources/Public/CSS/Sitemap.xsldeleted+0 −138
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl1.typoscriptdeleted+0 −5
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl2.typoscriptdeleted+0 −6
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl3.typoscriptdeleted+0 −13
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php+0 −23
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapXslTest.phpdeleted+0 −149
Review log 1115
-
Maike Kiebele uploaded patch set 1 09/30/26, 15:39
-
core-ci voted on patch set 1 V -1 09/30/26, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109662
-
Georg Ringer commented on patch set 1 10/01/26, 18:55
I suggest fixing that also down to 14 + 13.4 and also in ELTS. as it doesn't break anything I would just go with an Important rst -
Markus Klein commented on patch set 1 10/01/26, 20:03
Are there other ways to preserve those nicely formatted sitemaps? We actually liked this a lot. -
Georg Ringer commented on patch set 1 10/02/26, 06:21
see https://developer.chrome.com/docs/web-platform/deprecating-xslt?hl=de#xml_css_is_not_being_removed + below for alternatives -
Markus Klein commented on patch set 1 10/02/26, 06:57
Reply
Sure, but should we ship an alternative with core again instead of throwing this away compeletely? -
Maike Kiebele uploaded patch set 2
V -110/05/26, 07:04 -
core-ci voted on patch set 2 V -1 10/05/26, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110071
-
Maike Kiebele uploaded patch set 3
V -110/05/26, 13:09 -
core-ci voted on patch set 3 V +1 10/05/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110115
-
Maike Kiebele rebased onto patch set 4
V +110/24/26, 06:20 -
core-ci voted on patch set 4 V +1 10/24/26, 06:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112394
-
Benni Mack commented on patch set 4 11/06/26, 09:15
Reply
I built it like this from a client project of mine... what do you think? https://review.typo3.org/c/Packages/TYPO3.CMS/+/97389 -
Garvin Hicking commented on patch set 4 11/06/26, 18:52
Reply Unresolved
I would prefer the solution of yours since I think other browser vendors still support it, and the instance maintainer should IMO decide that, not our product in this case...? -
Garvin Hicking abandoned the change 11/11/26, 12:59
closing, other patch wass merged, hope its fine