Review main Merged

96231[TASK] Split CLI smoke tests by owning system extension

Wouter Wolters CR +2 V +2 Hard +370 −38 updated 10/12/26, 18:57

Commit message

Move CLI smoke tests into the system extension owning each command.
Preserve all 29 subprocess cases and load only required extensions.
Remove the resolved TODO and compare exit codes strictly.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1112

  1. Wouter Wolters uploaded patch set 1 09/30/26, 19:59

  2. Wouter Wolters wrote 10/06/26, 16:36

    Unset private
  3. Wouter Wolters updated the commit message in patch set 2 10/06/26, 16:36

  4. Wouter Wolters updated the commit message in patch set 3 10/06/26, 16:37

  5. core-ci voted on patch set 3 V +1 10/06/26, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110242

  6. Wouter Wolters marked it ready for review 10/06/26, 16:46

  7. Georg Ringer voted on patch set 3 CR +1 V +1 10/06/26, 16:50

  8. Simon Schaufelberger commented on patch set 3 10/06/26, 19:54

    CliCommandTest.php:93 Unresolved

    i wonder if we should leave the comments there?
  9. Oliver Klee voted on patch set 3 V +1 10/07/26, 09:50

  10. Benni Mack voted on patch set 3 CR +1 V +1 10/12/26, 18:54

  11. Georg Ringer voted on patch set 3 CR +2 V +2 10/12/26, 18:57

  12. Georg Ringer merged patch set 4 10/12/26, 18:57