Review main Merged

96235[TASK] Convert intExplode values without references

Wouter Wolters CR +2 V +2 Easy +4 −13 updated 10/19/26, 18:17

Commit message

Convert values in place with an indexed loop while preserving integer
casting, empty-value removal and contiguous keys. Avoid references
and keep peak memory at or below the original implementation.

Benchmarked on PHP 8.5.7, Ryzen 9 9955HX3D, OPcache enabled, JIT and
Xdebug disabled. Three runs of 15 alternating paired batches across
46 cases show median execution times 6-27% lower. Cases cover empty
input and 1-10,000 tokens, varying empty values and both removal modes.

Memory for 100,000 tokens (active PHP allocations, excluding input):
                         Before       After
Numeric IDs, peak        5.06 MiB     5.06 MiB
Numeric IDs, retained    5.06 MiB     2.00 MiB
50% removed, peak        4.53 MiB     3.53 MiB

All measured outputs match the original implementation exactly.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Markus Klein +1
    • Alexander Schnitzler +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Markus Klein +1
    • Alexander Schnitzler +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1821

  1. Wouter Wolters uploaded patch set 1 09/30/26, 20:27

  2. Wouter Wolters uploaded patch set 2 09/30/26, 21:02

  3. Wouter Wolters uploaded patch set 3 09/30/26, 21:11

  4. Wouter Wolters updated the commit message in patch set 4 10/07/26, 20:31

  5. Wouter Wolters wrote 10/07/26, 20:31

    Unset private
  6. Wouter Wolters marked it ready for review 10/07/26, 20:31

  7. core-ci voted on patch set 4 V +1 10/07/26, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110408

  8. Oliver Klee voted on patch set 4 CR +1 V +1 10/08/26, 16:45

  9. Josua Vogel voted on patch set 4 CR +1 10/08/26, 20:35

  10. Wouter Wolters uploaded patch set 5 CR +1 V +1 10/09/26, 20:58

  11. core-ci voted on patch set 5 V +1 10/09/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110723

  12. Josua Vogel voted on patch set 5 CR +1 V +1 10/10/26, 06:59

  13. Oliver Klee voted on patch set 5 CR +1 V +1 10/10/26, 08:28

  14. Wouter Wolters uploaded patch set 6 CR +1 V +1 10/17/26, 14:07

  15. core-ci voted on patch set 6 V +1 10/17/26, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111465

  16. Alexander Schnitzler voted on patch set 6 CR +1 V +1 10/17/26, 16:47

  17. Oliver Klee voted on patch set 6 CR +1 V +1 10/17/26, 16:57

  18. Simon Schaufelberger voted on patch set 6 CR +1 V +1 10/17/26, 17:31

  19. Markus Klein voted on patch set 6 CR +1 V +1 10/19/26, 16:53

  20. Georg Ringer voted on patch set 6 CR +2 V +2 10/19/26, 17:35

  21. Georg Ringer merged patch set 7 10/19/26, 18:17