Review main Merged

96238[TASK] Remove redundant service object check

Wouter Wolters CR +2 V +2 Easy +14 −22 updated 10/09/26, 16:15

Commit message

Correct the service object annotation to match makeInstance()'s object
return and remove the redundant is_object() check. Keep the legacy
service init validation and error handling unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Wouter Wolters uploaded patch set 1 09/30/26, 21:13

  2. Wouter Wolters updated the commit message in patch set 2 10/08/26, 16:21

  3. Wouter Wolters wrote 10/08/26, 16:21

    Unset private
  4. Wouter Wolters marked it ready for review 10/08/26, 16:21

  5. core-ci voted on patch set 2 V +1 10/08/26, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110516

  6. Oliver Klee voted on patch set 2 CR +1 V +1 10/08/26, 16:43

  7. Georg Ringer voted on patch set 2 CR +1 V +1 10/08/26, 18:11

  8. Benni Mack voted on patch set 2 CR +2 V +2 10/09/26, 16:15

  9. Benni Mack merged patch set 3 10/09/26, 16:15