Review main Merged

96242[TASK] Document the mutable container in BootService

Wouter Wolters CR +2 V +2 Easy +6 −9 updated 10/10/26, 06:31

Commit message

The container builder returns a PSR container interface, but the
non-failsafe container used during boot extends Symfony Container.
Narrow the local instance before registering early services and keep
the instance stored on BootService for the rest of the boot process.

Remove the two matching undefined set() method baseline occurrences.
The failsafe container and public signatures remain unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Wouter Wolters uploaded patch set 1 09/30/26, 21:54

  2. Wouter Wolters updated the commit message in patch set 2 10/09/26, 16:28

  3. Wouter Wolters wrote 10/09/26, 16:28

    Unset private
  4. Wouter Wolters marked it ready for review 10/09/26, 16:28

  5. core-ci voted on patch set 2 V -1 10/09/26, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110632

  6. Wouter Wolters rebased onto patch set 3 V -1 10/09/26, 17:22

  7. Oliver Klee voted on patch set 3 CR +1 V +1 10/09/26, 17:29

  8. core-ci voted on patch set 3 V +1 10/09/26, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110659

  9. Benni Mack voted on patch set 3 CR +2 V +2 10/10/26, 06:31

  10. Benni Mack merged patch set 4 10/10/26, 06:31