Review main Merged

96243[TASK] Require a mutable container in message worker

Wouter Wolters CR +2 V +2 Easy +3 −7 updated 10/20/26, 15:36

Commit message

Require Symfony's ContainerInterface for the container used to register
worker stop-limit listeners. Its set() method is absent from the PSR
interface used by the receiver and rate-limiter locators.

Explicitly inject service_container and remove the matching PHPStan
baseline occurrence without changing listener registration behavior.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Wouter Wolters uploaded patch set 1 09/30/26, 21:59

  2. Wouter Wolters updated the commit message in patch set 2 10/09/26, 16:29

  3. Wouter Wolters wrote 10/09/26, 16:29

    Unset private
  4. Wouter Wolters marked it ready for review 10/09/26, 16:29

  5. Wouter Wolters rebased onto patch set 3 10/09/26, 16:31

  6. core-ci voted on patch set 3 V +1 10/09/26, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110638

  7. core-ci voted on patch set 2 V -1 10/09/26, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110633

  8. Markus Klein commented on patch set 3 10/12/26, 21:32

    ConsumeMessagesCommand.php:70

    Better require here, what we actually need and don't rely below that this "most probably is a Container"
  9. Wouter Wolters uploaded patch set 4 V +1 10/14/26, 15:47

  10. Wouter Wolters commented on patch set 4 10/14/26, 15:48

    ConsumeMessagesCommand.php:70 Reply

    Done
  11. core-ci voted on patch set 4 V +1 10/14/26, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111125

  12. Oliver Klee voted on patch set 4 CR +1 V +1 10/14/26, 17:28

  13. Markus Klein voted on patch set 4 CR +1 V +1 10/14/26, 19:22

  14. Benni Mack voted on patch set 4 CR +2 V +2 10/20/26, 15:36

  15. Benni Mack merged patch set 5 10/20/26, 15:36