Review main Merged

96244[TASK] Align tree root types with renderers

Wouter Wolters CR +2 V +2 Easy +5 −14 updated 10/14/26, 16:36

Commit message

Tree renderers require TreeRepresentationNode, but AbstractTree and
its data provider document their roots as the broader TreeNode type.
The database tree provider already returns DatabaseTreeNode, which
extends TreeRepresentationNode.

Document TreeRepresentationNode in the shared root contracts and in
TableConfigurationTree. This lets PHPStan check the provider-to-tree
contract instead of trusting a local assertion in ArrayTreeRenderer.
Remove the equivalent assertion from UnorderedListTreeRenderer and
the matching PHPStan baseline entry.

PHP method signatures and rendering behavior remain unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1315

  1. Wouter Wolters uploaded patch set 1 09/30/26, 22:03

  2. Wouter Wolters uploaded patch set 2 10/12/26, 19:34

  3. Wouter Wolters rebased onto patch set 3 10/12/26, 20:04

  4. Wouter Wolters wrote 10/12/26, 20:04

    Unset private
  5. core-ci voted on patch set 3 V +1 10/12/26, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110948

  6. Georg Ringer voted on patch set 3 CR +1 V +1 10/12/26, 20:33

  7. Josua Vogel voted on patch set 3 CR +1 V +1 10/12/26, 20:36

  8. Markus Klein commented on patch set 3 10/12/26, 21:30

    ArrayTreeRenderer.php:103

    I think this is not optimal. This simply hides a mistake in the architecture.
  9. Wouter Wolters commented on patch set 3 10/13/26, 17:04

    ArrayTreeRenderer.php:103 Reply

    Done
  10. Wouter Wolters uploaded patch set 4 CR +1 V +1 10/13/26, 17:04

  11. core-ci voted on patch set 4 V +1 10/13/26, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111015

  12. Markus Klein voted on patch set 4 CR +1 V +1 10/13/26, 21:07

  13. Oliver Klee voted on patch set 4 CR +1 V +1 10/14/26, 10:03

  14. Benni Mack voted on patch set 4 CR +2 V +2 10/14/26, 16:36

  15. Benni Mack merged patch set 5 10/14/26, 16:36