Review main Merged

96254[BUGFIX] Reset LanguageMenuProcessor state per call

Nikita Hovratov CR +2 V +2 Normal +118 −5 updated 10/09/26, 16:49

Commit message

LanguageMenuProcessor merged the processor configuration into the
menu configuration of the previous call and appended the
canonicalization parameters to the already existing exclude list.

HrefLangGenerator is a shared event listener holding a single
LanguageMenuProcessor instance. In long-running worker processes
every request added another "id" to "addQueryString.exclude" until
parse_str() hit max_input_vars. Settings of a previous call, like
"addQueryString", leaked into subsequent calls as well.

The menu configuration now starts from its declared defaults on
every call.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Nikita Hovratov uploaded patch set 1 10/01/26, 09:25

  2. core-ci voted on patch set 1 V -1 10/01/26, 09:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109774

  3. Nikita Hovratov uploaded patch set 2 V -1 10/01/26, 09:42

  4. core-ci voted on patch set 2 V +1 10/01/26, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109777

  5. Georg Ringer voted on patch set 2 CR +1 V +1 10/01/26, 21:10

  6. Benni Mack voted on patch set 2 CR +2 V +2 10/09/26, 16:48

  7. Benni Mack merged patch set 3 10/09/26, 16:49