Review main Merged

96255[BUGFIX] Keep translated page relations when copying in workspaces

Benni Mack CR +2 V +2 Hard +405 −12 updated 10/02/26, 12:54

Commit message

When a translated page is copied in a workspace, the file references
and inline children of the translated copy got the uid of the
translated page as pid instead of the default language page: the live
id lookup overwrote the already resolved default language page id.

PageRepository::getLanguageOverlay() looks up translations on the pid
of the default language record, so these relations, e.g. page media,
went missing in the frontend.

The default language page is now resolved after the live id, which
aligns the workspace behaviour with live. Two IRRE workspace datasets
encoded the wrong pid and are corrected. New FAL scenarios cover
copying and moving a translated page with media, and an IRRE scenario
covers moving translated content with children.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • David Steeb +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • David Steeb +1
    • core-ci +1 CI

Issues 1

Files 30

Show 10 more files

Review log 68

  1. Benni Mack uploaded patch set 1 10/01/26, 09:44

  2. core-ci voted on patch set 1 V -1 10/01/26, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109778

  3. Benni Mack uploaded patch set 2 V -1 10/02/26, 12:15

  4. David Steeb voted on patch set 2 CR +1 V +1 10/02/26, 12:19

  5. core-ci voted on patch set 2 V +1 10/02/26, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109931

  6. Georg Ringer voted on patch set 2 CR +1 V +1 10/02/26, 12:26

  7. Benni Mack voted on patch set 2 CR +2 V +2 10/02/26, 12:54

  8. Benni Mack merged patch set 3 10/02/26, 12:54