Review main Merged

96257[BUGFIX] Load CKEditor styles in form editor

Josua Vogel CR +2 V +2 Easy +15 −4 updated 10/02/26, 07:46

Commit message

The Form Editor initializes CKEditor 5 but does not load its UI stylesheet.
Register editor.css when rte_ckeditor is active so the toolbar and editing
area render with the expected styles.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Josua Vogel uploaded patch set 1 10/01/26, 11:22

  2. Benni Mack commented on patch set 1 10/01/26, 11:30

    FormEditorController.php:196

    please don't... :( tbh, this is an issue, because no other RTE can then inject their own styles.
  3. core-ci voted on patch set 1 V +1 10/01/26, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109787

  4. Josua Vogel commented on patch set 1 10/01/26, 13:15

    FormEditorController.php:196 Reply

    Talked with Benni: The best thing would be to have an event where an RTE can be integrated. That can't be implemented very quickly. The patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/90612 provides a good foundation and should be prioritized for v15. After that, the RTE parts can be adjusted in form. This patch should be merged specifically for 14.3 so that the RTE works in form in the next release.
  5. Georg Ringer voted on patch set 1 CR +1 V +1 10/01/26, 18:21

  6. Benjamin Franzke commented on patch set 1 CR +2 V +2 10/02/26, 06:48

    FormEditorController.php:196 Reply

    Yes, not nice, but the tight coupling already exists in `Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts` anyway. Btw, we *might* get away of this part in here by letting the ckeditor webcomponent inject it's needed style in future [1], but for the time being this is fine. [1] See https://review.typo3.org/c/Packages/TYPO3.CMS/+/96032/2/Build/Sources/TypeScript/rte-ckeditor/ckeditor5.ts#225
  7. Benjamin Franzke merged patch set 2 10/02/26, 07:46