96260[TASK] Correct commit-msg hook notes in AGENTS.md
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 3
Files 1
Review log 1216
-
Olivier Dobberkau uploaded patch set 1 10/01/26, 14:22
-
Olivier Dobberkau commented on patch set 1 10/01/26, 14:25
AI-assisted contribution: prepared with Claude Code under my supervision. I reviewed every line of the diff and take responsibility for this change. The described hook behaviour was verified locally (exit code 0 for a 73-character line and a missing Resolves line). -
core-ci voted on patch set 1 V +1 10/01/26, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109809
-
Wouter Wolters voted on patch set 1 CR +1 V +1 10/01/26, 16:51
-
Josua Vogel commented on patch set 1 10/08/26, 20:50
AGENTS.md:254Perhaps this part could also be described more clearly. In principle, it is possible to mark multiple issues as “Resolved,” so in my opinion, this wording is incorrect or ambiguous. “Related” should refer to issues related to this change that are not resolved. -
Olivier Dobberkau uploaded patch set 2
CR +1V +110/19/26, 12:34 -
Olivier Dobberkau commented on patch set 2 10/19/26, 12:36
AGENTS.md:254ReplyThanks, good point. The hook itself asks for "at least one" Resolves: line, so several are fine. Patch set 2 says so explicitly and limits Related: to issues that are connected to the change but not resolved by it. -
Olivier Dobberkau commented on patch set 2 10/19/26, 12:38
Reply
Acknowledged -
core-ci voted on patch set 2 V -1 10/19/26, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111641
-
Olivier Dobberkau rebased onto patch set 3
V -110/19/26, 12:58 -
core-ci voted on patch set 3 V +1 10/19/26, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111646
-
Garvin Hicking updated the commit message in patch set 4
V +110/19/26, 14:52 -
Garvin Hicking voted on patch set 4 CR +1 V +1 10/19/26, 14:52
-
core-ci voted on patch set 4 V +1 10/19/26, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111665
-
Benni Mack commented on patch set 4 CR +2 V +2 10/19/26, 15:52
AGENTS.md:254ReplyDone -
Benni Mack merged patch set 5 10/19/26, 15:52