Review main Merged

96262[BUGFIX] Prevent record actions on paginator enter

Oli Bartsch CR +2 V +2 Normal +200 −49 updated 10/01/26, 19:37

Commit message

Since the record actions in the list module are rendered via
GenericButton and DropDownItem, they lack an explicit button type
and thus act as submit buttons. Pressing enter in the paginator
input therefore triggered the implicit form submission, which
activated the first action of the first record, e.g. the
hide/unhide toggle or the info window.

GenericButton and dropdown items now render type="button" for
button tags, unless a type is set explicitly. The "show" title
link button gets an explicit type as well. Additionally, the
paginator input prevents the implicit form submission on keydown.

The helper to set user TSconfig in e2e tests is extracted to be
reused by the new pagination test.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1418

  1. Oli Bartsch uploaded patch set 1 10/01/26, 16:35

  2. Oli Bartsch updated the commit message in patch set 2 10/01/26, 16:36

  3. Markus Timtner commented on patch set 2 CR +1 V +1 10/01/26, 16:43

    Good work! seems like the minimalist possible fix for this.
  4. core-ci voted on patch set 1 V +1 10/01/26, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109814

  5. core-ci voted on patch set 2 V +1 10/01/26, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109815

  6. Markus Klein commented on patch set 2 V -1 10/01/26, 16:47

    in my testcase now the information window appears when hitting enter
  7. Markus Klein commented on patch set 2 10/01/26, 16:57

    Reply

    Tested on v14
  8. Oli Bartsch uploaded patch set 3 CR +1 V +1 10/01/26, 17:00

  9. core-ci voted on patch set 3 V +1 10/01/26, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109819

  10. Markus Klein voted on patch set 3 CR +1 V +1 10/01/26, 17:19

  11. Markus Klein commented on patch set 3 10/01/26, 17:46

    Reply

    Done
  12. Markus Klein commented on patch set 3 CR 0 10/01/26, 18:26

    v14 is now missing?
  13. Georg Ringer updated the commit message in patch set 4 V +1 10/01/26, 18:27

  14. Georg Ringer voted on patch set 4 CR +1 V +1 10/01/26, 18:27

  15. Markus Klein voted on patch set 4 CR +1 V +1 10/01/26, 18:29

  16. core-ci voted on patch set 4 V +1 10/01/26, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109826

  17. Oli Bartsch voted on patch set 4 CR +2 V +2 10/01/26, 19:37

  18. Oli Bartsch merged patch set 5 10/01/26, 19:37