96262[BUGFIX] Prevent record actions on paginator enter
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Markus Klein +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/backend/recordlist.ts+5 −0
- Build/tests/playwright/e2e/records/record-download-with-preset.spec.ts+1 −47
- Build/tests/playwright/e2e/records/record-list-pagination.spec.tsnew+43 −0
- Build/tests/playwright/helper/user-tsconfig.tsnew+47 −0
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/AbstractDropDownItem.php+3 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/GenericButton.php+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/recordlist.js+1 −1
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/DropDownItemTest.phpnew+48 −0
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/GenericButtonTest.phpnew+48 −0
Review log 1418
-
Oli Bartsch uploaded patch set 1 10/01/26, 16:35
-
Oli Bartsch updated the commit message in patch set 2 10/01/26, 16:36
-
Markus Timtner commented on patch set 2 CR +1 V +1 10/01/26, 16:43
Good work! seems like the minimalist possible fix for this. -
core-ci voted on patch set 1 V +1 10/01/26, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109814
-
core-ci voted on patch set 2 V +1 10/01/26, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109815
-
Markus Klein commented on patch set 2 V -1 10/01/26, 16:47
in my testcase now the information window appears when hitting enter -
Markus Klein commented on patch set 2 10/01/26, 16:57
Reply
Tested on v14 -
Oli Bartsch uploaded patch set 3
CR +1V +110/01/26, 17:00 -
core-ci voted on patch set 3 V +1 10/01/26, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109819
-
Markus Klein voted on patch set 3 CR +1 V +1 10/01/26, 17:19
-
Markus Klein commented on patch set 3 10/01/26, 17:46
Reply
Done -
Markus Klein commented on patch set 3 CR 0 10/01/26, 18:26
v14 is now missing? -
Georg Ringer updated the commit message in patch set 4
V +110/01/26, 18:27 -
Georg Ringer voted on patch set 4 CR +1 V +1 10/01/26, 18:27
-
Markus Klein voted on patch set 4 CR +1 V +1 10/01/26, 18:29
-
core-ci voted on patch set 4 V +1 10/01/26, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109826
-
Oli Bartsch voted on patch set 4 CR +2 V +2 10/01/26, 19:37
-
Oli Bartsch merged patch set 5 10/01/26, 19:37