Review main Merged

96265[TASK] Document the equi-join condition in DataMapper

Wouter Wolters CR +2 V +2 Easy +4 −7 updated 10/09/26, 18:40

Commit message

DataMapper builds m:n relation sources with an equi-join condition.
The query source exposes only the broader join-condition interface,
which does not declare getProperty1Name().

Document the local condition type when constraining workspace
relations and remove the matching PHPStan baseline occurrence.
Query behavior and public signatures remain unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Wouter Wolters uploaded patch set 1 10/01/26, 18:17

  2. Wouter Wolters updated the commit message in patch set 2 10/09/26, 17:57

  3. Wouter Wolters wrote 10/09/26, 17:57

    Unset private
  4. Wouter Wolters rebased onto patch set 3 10/09/26, 17:57

  5. Wouter Wolters marked it ready for review 10/09/26, 17:57

  6. core-ci voted on patch set 3 V +1 10/09/26, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110666

  7. Benni Mack voted on patch set 3 CR +2 V +2 10/09/26, 18:40

  8. Benni Mack merged patch set 4 10/09/26, 18:40