Review main Merged

96267[TASK] Refresh extension configuration before checking a path

Wouter Wolters CR +2 V +2 Easy +28 −7 updated 10/13/26, 10:22

Commit message

Extension configuration synchronization can populate a missing path
in the global configuration. Read the refreshed configuration into
a local variable before checking that path again, so PHPStan does
not reuse its conclusion from the first check of the global array.

Keep the post-synchronization guard and remove its baseline entry.
Cover paths appearing during synchronization and paths remaining
absent with unit tests. Runtime behavior stays unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1215

  1. Wouter Wolters uploaded patch set 1 10/01/26, 18:27

  2. Wouter Wolters updated the commit message in patch set 2 10/09/26, 16:16

  3. Wouter Wolters wrote 10/09/26, 16:16

    Unset private
  4. Wouter Wolters marked it ready for review 10/09/26, 16:16

  5. core-ci voted on patch set 2 V -1 10/09/26, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110628

  6. Wouter Wolters rebased onto patch set 3 V -1 10/09/26, 16:31

  7. core-ci voted on patch set 3 V +1 10/09/26, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110636

  8. Oliver Klee voted on patch set 3 CR +1 V +1 10/09/26, 17:29

  9. Wouter Wolters uploaded patch set 4 CR +1 V +1 10/10/26, 18:53

  10. core-ci voted on patch set 4 V +1 10/10/26, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110816

  11. Oliver Klee voted on patch set 4 CR +1 V +1 10/10/26, 19:10

  12. Markus Klein voted on patch set 4 CR +1 V +1 10/12/26, 21:18

  13. Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/13/26, 08:36

  14. Benni Mack voted on patch set 4 CR +2 V +2 10/13/26, 10:22

  15. Benni Mack merged patch set 5 10/13/26, 10:22