Review main Merged

96269[TASK] Document image files in ClickEnlargeViewHelper

Wouter Wolters CR +2 V +2 Easy +3 −7 updated 10/09/26, 19:46

Commit message

The media template passes original File or FileReference objects
to the click-enlarge ViewHelper. Document these concrete types for
the local image passed to imageLinkWrap(), which accepts both.

Remove the matching PHPStan baseline occurrence without changing
argument registration or rendering behavior.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 910

  1. Wouter Wolters uploaded patch set 1 10/01/26, 18:39

  2. Wouter Wolters updated the commit message in patch set 2 10/09/26, 18:05

  3. Wouter Wolters rebased onto patch set 3 10/09/26, 18:05

  4. Wouter Wolters wrote 10/09/26, 18:05

    Unset private
  5. Wouter Wolters marked it ready for review 10/09/26, 18:05

  6. core-ci voted on patch set 3 V +1 10/09/26, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110673

  7. Josua Vogel voted on patch set 3 CR +1 10/09/26, 19:31

  8. Georg Ringer voted on patch set 3 CR +1 V +1 10/09/26, 19:45

  9. Benni Mack voted on patch set 3 CR +2 V +2 10/09/26, 19:46

  10. Benni Mack merged patch set 4 10/09/26, 19:46