96270[TASK] Type recursive form renderables with generics
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 6
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php2+2 −0
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractCompositeRenderable.php+11 −8
- typo3/sysext/form/Classes/Domain/Model/Renderable/CompositeRenderableInterface.php+3 −1
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+1 −0
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+37 −0
Review log 1215
-
Wouter Wolters uploaded patch set 1 10/01/26, 18:43
-
Wouter Wolters updated the commit message in patch set 2 10/09/26, 18:28
-
Wouter Wolters rebased onto patch set 3 10/09/26, 18:28
-
Wouter Wolters wrote 10/09/26, 18:28
Unset private -
Wouter Wolters marked it ready for review 10/09/26, 18:28
-
core-ci voted on patch set 3 V +1 10/09/26, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110679
-
Wouter Wolters uploaded patch set 4
V +110/10/26, 18:39 -
core-ci voted on patch set 4 V +1 10/10/26, 18:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110814
-
Oliver Klee commented on patch set 4 10/11/26, 07:32
AbstractSection.php:83This feels … a bit risky to me. Would it make sense to use generics for getRenderablesRecursively instead? -
Wouter Wolters uploaded patch set 5
V +110/11/26, 09:46 -
Wouter Wolters commented on patch set 5 10/11/26, 09:46
AbstractSection.php:83ReplyDone -
core-ci voted on patch set 5 V +1 10/11/26, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110843
-
Oliver Klee voted on patch set 5 CR +1 V +1 10/11/26, 12:34
-
Benni Mack voted on patch set 5 CR +2 V +2 10/12/26, 09:05
-
Benni Mack merged patch set 6 10/12/26, 09:05