Review main Merged

96270[TASK] Type recursive form renderables with generics

Wouter Wolters CR +2 V +2 Normal +54 −15 updated 10/12/26, 09:05

Commit message

Express the child renderable type in AbstractCompositeRenderable and
CompositeRenderableInterface with generics. Specialize AbstractSection
for FormElementInterface while keeping FormDefinition's recursive
collection broad enough to include pages and their descendants.

Remove the local type assertion from getElementsRecursively() and its
PHPStan baseline occurrence. Keep traversal and native signatures
unchanged.

Cover empty sections, nested elements, traversal order and recursive
form traversal including pages. Leave the separate setOptions()
baseline finding for follow-up.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1215

  1. Wouter Wolters uploaded patch set 1 10/01/26, 18:43

  2. Wouter Wolters updated the commit message in patch set 2 10/09/26, 18:28

  3. Wouter Wolters rebased onto patch set 3 10/09/26, 18:28

  4. Wouter Wolters wrote 10/09/26, 18:28

    Unset private
  5. Wouter Wolters marked it ready for review 10/09/26, 18:28

  6. core-ci voted on patch set 3 V +1 10/09/26, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110679

  7. Wouter Wolters uploaded patch set 4 V +1 10/10/26, 18:39

  8. core-ci voted on patch set 4 V +1 10/10/26, 18:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110814

  9. Oliver Klee commented on patch set 4 10/11/26, 07:32

    AbstractSection.php:83

    This feels … a bit risky to me. Would it make sense to use generics for getRenderablesRecursively instead?
  10. Wouter Wolters uploaded patch set 5 V +1 10/11/26, 09:46

  11. Wouter Wolters commented on patch set 5 10/11/26, 09:46

    AbstractSection.php:83 Reply

    Done
  12. core-ci voted on patch set 5 V +1 10/11/26, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110843

  13. Oliver Klee voted on patch set 5 CR +1 V +1 10/11/26, 12:34

  14. Benni Mack voted on patch set 5 CR +2 V +2 10/12/26, 09:05

  15. Benni Mack merged patch set 6 10/12/26, 09:05