Review main Merged

96271[TASK] Type configured form element class names

Wouter Wolters CR +2 V +2 Easy +2 −6 updated 10/13/26, 21:10

Commit message

Form elements configured in type definitions implement both
FormElementInterface and VariableRenderableInterface. The latter
provides setOptions(), which FormElementInterface does not declare.

Annotate the implementation class name as a class-string of the
interface intersection. GeneralUtility::makeInstance() propagates
that type to the created element, so setOptions() can be called
without a separate local object assertion.

Remove the matching PHPStan baseline entry. Keep the runtime
form-element validation and initialization unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1722

  1. Wouter Wolters uploaded patch set 1 10/01/26, 18:52

  2. Wouter Wolters updated the commit message in patch set 2 10/09/26, 18:46

  3. Wouter Wolters rebased onto patch set 3 10/09/26, 18:46

  4. Wouter Wolters wrote 10/09/26, 18:47

    Unset private
  5. Wouter Wolters marked it ready for review 10/09/26, 18:47

  6. core-ci voted on patch set 3 V +1 10/09/26, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110689

  7. Benni Mack updated the commit message in patch set 4 V +1 10/09/26, 19:13

  8. core-ci voted on patch set 4 V +1 10/09/26, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110697

  9. Josua Vogel voted on patch set 4 CR +1 V +1 10/09/26, 19:30

  10. Wouter Wolters uploaded patch set 5 CR +1 V +1 10/09/26, 20:16

  11. core-ci voted on patch set 5 V +1 10/09/26, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110711

  12. Wouter Wolters commented on patch set 5 CR -1 10/11/26, 11:44

  13. Wouter Wolters uploaded patch set 6 CR -1 V +1 10/12/26, 17:00

  14. Josua Vogel voted on patch set 6 CR +1 V +1 10/12/26, 17:05

  15. core-ci voted on patch set 6 V +1 10/12/26, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110912

  16. Markus Klein commented on patch set 6 10/12/26, 21:20

    AbstractSection.php:138

    Here we should add: ```suggestion /** @var class-string<FormElementInterface&VariableRenderableInterface> */ $implementationClassName = $typeDefinition['implementationClassName']; ``` Then we shouldn't need the direct type below.
  17. Wouter Wolters uploaded patch set 7 CR +1 V +1 10/13/26, 17:14

  18. Wouter Wolters commented on patch set 7 10/13/26, 17:14

    AbstractSection.php:138 Reply

    Done
  19. core-ci voted on patch set 7 V +1 10/13/26, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111016

  20. Markus Klein voted on patch set 7 CR +1 V +1 10/13/26, 21:08

  21. Benni Mack voted on patch set 7 CR +2 V +2 10/13/26, 21:10

  22. Benni Mack merged patch set 8 10/13/26, 21:10