96271[TASK] Type configured form element class names
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1722
-
Wouter Wolters uploaded patch set 1 10/01/26, 18:52
-
Wouter Wolters updated the commit message in patch set 2 10/09/26, 18:46
-
Wouter Wolters rebased onto patch set 3 10/09/26, 18:46
-
Wouter Wolters wrote 10/09/26, 18:47
Unset private -
Wouter Wolters marked it ready for review 10/09/26, 18:47
-
core-ci voted on patch set 3 V +1 10/09/26, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110689
-
Benni Mack updated the commit message in patch set 4
V +110/09/26, 19:13 -
core-ci voted on patch set 4 V +1 10/09/26, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110697
-
Josua Vogel voted on patch set 4 CR +1 V +1 10/09/26, 19:30
-
Wouter Wolters uploaded patch set 5
CR +1V +110/09/26, 20:16 -
core-ci voted on patch set 5 V +1 10/09/26, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110711
-
Wouter Wolters commented on patch set 5 CR -1 10/11/26, 11:44
on hold till https://review.typo3.org/c/Packages/TYPO3.CMS/+/96270 is merged -
Wouter Wolters uploaded patch set 6
CR -1V +110/12/26, 17:00 -
Josua Vogel voted on patch set 6 CR +1 V +1 10/12/26, 17:05
-
core-ci voted on patch set 6 V +1 10/12/26, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110912
-
Markus Klein commented on patch set 6 10/12/26, 21:20
AbstractSection.php:138Here we should add: ```suggestion /** @var class-string<FormElementInterface&VariableRenderableInterface> */ $implementationClassName = $typeDefinition['implementationClassName']; ``` Then we shouldn't need the direct type below. -
Wouter Wolters uploaded patch set 7
CR +1V +110/13/26, 17:14 -
Wouter Wolters commented on patch set 7 10/13/26, 17:14
AbstractSection.php:138ReplyDone -
core-ci voted on patch set 7 V +1 10/13/26, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111016
-
Markus Klein voted on patch set 7 CR +1 V +1 10/13/26, 21:08
-
Benni Mack voted on patch set 7 CR +2 V +2 10/13/26, 21:10
-
Benni Mack merged patch set 8 10/13/26, 21:10