96272[TASK] Read the current session after authentication validation
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Markus Klein +1
- Josua Vogel +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Markus Klein +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1517
-
Wouter Wolters uploaded patch set 1 10/01/26, 18:59
-
Wouter Wolters updated the commit message in patch set 2 10/09/26, 18:00
-
Wouter Wolters rebased onto patch set 3 10/09/26, 18:00
-
Wouter Wolters wrote 10/09/26, 18:00
Unset private -
Wouter Wolters marked it ready for review 10/09/26, 18:00
-
core-ci voted on patch set 3 V +1 10/09/26, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110668
-
Josua Vogel voted on patch set 3 CR +1 10/09/26, 19:33
-
Wouter Wolters uploaded patch set 4
CR +1V +110/12/26, 20:18 -
Josua Vogel voted on patch set 4 CR +1 10/12/26, 20:22
-
core-ci voted on patch set 4 V +1 10/12/26, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110950
-
Markus Klein commented on patch set 4 10/12/26, 21:24
I don't get it. The example does not make sense to me. And why does PHPStan complain about `$this->somevar` but not with `$somevar = $this->somevar` ? -
Oliver Klee voted on patch set 4 CR +1 V +1 10/13/26, 13:39
-
Wouter Wolters commented on patch set 4 10/13/26, 16:53
Reply
That has to do with how PHPstan remembers things when visiting the code. See https://phpstan.org/blog/remembering-and-forgetting-returned-values In this case isNew() initially returns false, so we enter the outer if. fetchValidUserFromSessionOrDestroySession() detects the expiry, calls logoff() and then createAnonymousSession(). createAnonymousSession() replaces $this->userSession with a new session whose isNew() returns true. -
Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/13/26, 16:59
-
Markus Klein voted on patch set 4 CR +1 V +1 10/13/26, 21:05
-
Benni Mack voted on patch set 4 CR +2 V +2 10/14/26, 11:52
-
Benni Mack merged patch set 5 10/14/26, 11:52