Review main Merged

96275[TASK] Fix the command processing flag annotation

Wouter Wolters CR +2 V +2 Easy +1 −7 updated 10/09/26, 17:50

Commit message

Place the bool annotation on the commandIsProcessed assignment instead
of the hook call. Hooks can set this flag by reference to skip the
built-in command handling. PHPStan currently treats it as always false
because the annotation is attached to the wrong statement.

Preserve the existing hook behavior and remove the matching PHPStan
baseline occurrence. This only moves a PHPDoc annotation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Wouter Wolters uploaded patch set 1 10/01/26, 19:15

  2. Wouter Wolters updated the commit message in patch set 2 10/09/26, 16:36

  3. Wouter Wolters rebased onto patch set 3 10/09/26, 16:36

  4. Wouter Wolters wrote 10/09/26, 16:36

    Unset private
  5. Wouter Wolters marked it ready for review 10/09/26, 16:36

  6. core-ci voted on patch set 3 V +1 10/09/26, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110645

  7. Benni Mack voted on patch set 3 CR +2 V +2 10/09/26, 17:50

  8. Benni Mack merged patch set 4 10/09/26, 17:50