96279[FEATURE] Add pagination to dashboard list widgets
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benjamin Kott +1
-
Verified V +2 Done
- Georg Ringer +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 19
- Build/Sources/Sass/dashboard/_widget.scss+15 −0
- Build/Sources/TypeScript/dashboard/dashboard.ts+38 −4
- Build/tests/playwright/e2e/dashboard/dashboard-module.spec.ts+47 −0
- Build/tests/playwright/fixtures/BackendEnvironment.csv+5 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-101534-PaginationForDashboardListWidgets.rstnew+68 −0
- typo3/sysext/dashboard/Classes/Widgets/Provider/LatestBeLoginsDataProvider.php+55 −17
- typo3/sysext/dashboard/Classes/Widgets/LatestBeLoginsWidget.php+7 −4
- typo3/sysext/dashboard/Classes/Widgets/ListWidget.php+47 −5
- typo3/sysext/dashboard/Classes/Widgets/PaginatedListDataProviderInterface.phpnew+34 −0
- typo3/sysext/dashboard/Documentation/Developer/Interfaces.rst+10 −0
- typo3/sysext/dashboard/Documentation/Widgets/ListWidget.rst+19 −2
- typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf+19 −1
- typo3/sysext/dashboard/Resources/Private/Partials/Widget/Pagination.fluid.htmlnew+33 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/LatestBeLoginsWidget.html+1 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/ListWidget.fluid.html+1 −0
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+3 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard.js+1 −1
- typo3/sysext/dashboard/Tests/Functional/Widgets/LatestBeLoginsWidgetTest.phpnew+179 −0
- typo3/sysext/dashboard/Tests/Functional/Widgets/ListWidgetTest.phpnew+227 −0
Review log 1418
-
Benni Mack uploaded patch set 1 10/01/26, 20:58
-
core-ci voted on patch set 1 V +1 10/01/26, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109841
-
Benni Mack marked it ready for review 10/08/26, 19:53
-
Benni Mack marked it work in progress 10/08/26, 19:54
-
Benni Mack uploaded patch set 2
V +110/09/26, 12:02 -
Benni Mack marked it ready for review 10/09/26, 12:02
-
core-ci voted on patch set 2 V -1 10/09/26, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110597
-
Benni Mack rebased onto patch set 3
V -110/09/26, 16:07 -
core-ci voted on patch set 3 V +1 10/09/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110623
-
Benni Mack uploaded patch set 4
V +110/16/26, 10:11 -
Benni Mack marked it ready for review 10/16/26, 10:11
-
core-ci voted on patch set 4 V +1 10/16/26, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111348
-
Guido Schmechel commented on patch set 4 10/16/26, 10:42
Does it make sense to put the current page number in an input field here? For example: I have a large number of pages and don't want to click through them x times. (Even if it's fast.) Also, there isn't quite enough padding between the pagination and the dashboard content. Try hovering over the element before the pagination. Then you'll see it pretty clearly. And something that might need to be clarified (later): How will the change affect large sys_log tables? Could this be a performance issue? Previously, it was limited. If I understand correctly, we could still adjust that, since 100 was specified as the maximum in the SettingsDefinition. So 100 * itemsPerPage. Or has that already been taken into account? -
Benjamin Kott commented on patch set 4 CR +1 V +1 10/16/26, 13:59
good enough for now -
Georg Ringer voted on patch set 4 CR +2 V +2 10/16/26, 17:50
-
Georg Ringer merged patch set 5 10/16/26, 17:50
-
Benni Mack commented on patch set 5 10/16/26, 17:55
Reply
Hey, I didn't want to leave this unnoticed... this patch is like a wish for 3 years, and we included it now. But: We will take care of your sugesstions separately. Performance should not be a problem in this case, as it is chunked in any case. But please open up a new issue for your ideas, don't worry, we will tackle thm -
Guido Schmechel commented on patch set 5 10/20/26, 15:18
Reply
Thanks for the explanation! Keep up the good work 😊