96295[BUGFIX] Handle null bytes in Extbase DateTimeConverter
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Alexander Schnitzler +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- Alexander Schnitzler +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 78
-
Georg Ringer uploaded patch set 1 10/02/26, 07:07
-
Georg Ringer commented on patch set 1 10/02/26, 07:07
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/02/26, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109878
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/09/26, 19:54
-
Markus Klein voted on patch set 1 CR +1 V +1 10/12/26, 19:16
-
Alexander Schnitzler commented on patch set 1 CR +1 V +1 10/13/26, 18:13
DateTimeConverter.php:131You could keep the existing, less complex nesting and catch \ValueError here as well and be done with your null byte. It's less explicit but also easier to understand. -
Benni Mack commented on patch set 1 CR +2 V +2 10/22/26, 15:51
DateTimeConverter.php:131ReplyI'll keep it as is. -
Benni Mack merged patch set 2 10/22/26, 15:52