Review 14.3 Merged

96296[BUGFIX] Respect enable field settings for Extbase MM relations

Georg Ringer CR +2 V +2 Normal +122 −0 updated 10/02/26, 07:52

Commit message

Extbase resolves MM relations with a query whose source is a join
of the MM table and the child table. For such queries, the Doctrine
QueryBuilder kept its DefaultRestrictionContainer, so "deleted",
"hidden", "starttime" and "endtime" of the child table were always
added to the join condition.

The query settings "ignoreEnableFields" and "enableFieldsToBeIgnored"
had no effect on these relations, hidden related records could never
be fetched and the "deleted" constraint ended up twice in the query.

The default restrictions are now removed for join queries as well,
as it is already done for regular queries. The visibility is then
handled by Extbase alone, based on the query settings.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 46

  1. Georg Ringer commented on patch set 1 10/02/26, 07:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/02/26, 07:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109879

  3. Georg Ringer uploaded patch set 2 V -1 10/02/26, 07:37

  4. core-ci voted on patch set 2 V +1 10/02/26, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109885

  5. Georg Ringer voted on patch set 2 CR +2 V +2 10/02/26, 07:52

  6. Georg Ringer merged patch set 3 10/02/26, 07:52