96300[FEATURE] Upload files in the file browser via drop and paste
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 12
- Build/Sources/Sass/component/_dropzone.scss+11 −1
- Build/Sources/TypeScript/backend/drag-uploader.ts+2 −1
- Build/Sources/TypeScript/filelist/browse-files.ts+15 −2
- Build/tests/playwright/e2e/form-engine/file-browser-upload.spec.tsnew+98 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+4 −2
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+2 −2
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110873-UploadFilesByPastingFromTheClipboard.rst+13 −4
- typo3/sysext/filelist/Classes/ElementBrowser/AbstractResourceBrowser.php+23 −0
- typo3/sysext/filelist/Classes/ElementBrowser/CreateFileBrowser.php+0 −23
- typo3/sysext/filelist/Classes/ElementBrowser/FileBrowser.php+14 −2
- typo3/sysext/filelist/Resources/Private/Templates/ElementBrowser/Files.fluid.html+10 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/browse-files.js+1 −1
Review log 1824
-
Oli Bartsch uploaded patch set 1 10/02/26, 08:18
-
core-ci voted on patch set 1 V +1 10/02/26, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109890
-
Simon Schaufelberger commented on patch set 1 10/02/26, 09:00
I've tested this feature and need to say thank you first of all! This is a huge UX improvement! When i drag a file into the file browser, the Drag&Drop bar appears which would assume that i can drop the file now wherever I want but that doesn't work. Instead i can only drop the file directly into the small bar. Can you please change it so that i can drop the file in the whole "content" area with the gray background? That would be perfect! -
Oli Bartsch uploaded patch set 2
V +110/02/26, 09:34 -
Oli Bartsch commented on patch set 2 10/02/26, 09:37
Reply
Thanks a lot for testing and the feedback! I changed this accordingly. - Files can now be dropped anywhere onto the content area of the file browser, not only onto the dropzone bar. While a file is dragged over that area, the bar is highlighted to show that dropping will upload it. - The folder tree is excluded on purpose: dropping a file onto a folder there would suggest uploading it into that folder, while the upload always goes to the folder currently shown. -
core-ci voted on patch set 2 V +1 10/02/26, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109896
-
Simon Schaufelberger commented on patch set 2 10/02/26, 09:44
Reply
would it be possible to show the drag&drop bar as a modal layer with a dimmed background the same way as the media module instead? then they would look identical. -
Oli Bartsch uploaded patch set 3
V +110/02/26, 10:10 -
Oli Bartsch commented on patch set 3 10/02/26, 10:11
Reply
👍 -
core-ci voted on patch set 3 V +1 10/02/26, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109902
-
Simon Schaufelberger commented on patch set 3 10/02/26, 14:29
Reply
great already! One more thing to be perfect is to remove the overlay again when you move your mouse out of the drop zone exactly like the media module. Then I'm happy. -
Simon Schaufelberger commented on patch set 3 10/02/26, 14:32
Reply
would it also be possible to only show the overlay when you move your mouse over the content area but not over the folder tree as you can't drop something over there (which is fine)? -
Oli Bartsch uploaded patch set 4
V +110/05/26, 09:42 -
core-ci voted on patch set 4 V +1 10/05/26, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110085
-
Oli Bartsch commented on patch set 4 10/05/26, 10:04
Reply
Done -
Simon Schaufelberger commented on patch set 4 CR +1 V +1 10/05/26, 23:19
works like a charm! Thank you so much for this huge improvement! -
Oli Bartsch uploaded patch set 5
CR +1V +110/07/26, 20:37 -
core-ci voted on patch set 5 V +1 10/07/26, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110410
-
Oli Bartsch uploaded patch set 6
V +110/07/26, 21:07 -
core-ci voted on patch set 6 V +1 10/07/26, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110416
-
Benni Mack voted on patch set 6 CR +1 V +1 10/07/26, 21:32
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 10/07/26, 23:01
-
Oli Bartsch voted on patch set 6 CR +2 V +2 10/08/26, 06:28
-
Oli Bartsch merged patch set 7 10/08/26, 06:28