Review main Merged

96301[BUGFIX] Keep records with invisible relations in Extbase queries

Georg Ringer CR +2 V +2 Hard +267 −16 updated 10/23/26, 09:15

Commit message

If a query references a property of a relation, e.g. a constraint
on "posts.title" or an ordering by "author.name", Extbase joins the
related table. The visibility constraints of that table were added
to the WHERE clause as "(visible OR uid IS NULL)".

A deleted or hidden related record is still joined, though, and its
row does not fulfill this condition. A record which only has such
relations was removed from the result, even if it matched another
part of an OR constraint or if the relation was only used for the
ordering.

The visibility constraints of joined tables are now part of the join
condition. Invisible related records are not joined anymore and can
still not match a constraint, while the record itself is kept.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Georg Ringer uploaded patch set 1 10/02/26, 08:29

  2. Georg Ringer commented on patch set 1 10/02/26, 08:29

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/02/26, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109891

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/09/26, 19:54

  5. Benni Mack voted on patch set 1 CR +2 V +2 10/23/26, 09:15

  6. Benni Mack merged patch set 2 10/23/26, 09:15