Review main Merged

96302[BUGFIX] Discard invalid mount point pairs in frontend requests

Georg Ringer CR +2 V +2 Easy +32 −2 updated 10/23/26, 15:14

Commit message

The MP parameter is excluded from the cHash calculation, so any
request can pass it. PageInformationFactory only removed characters
other than digits, comma and dash, which turned e.g. "MP=<sz2B"
into "2". This value ended up in generated links, and PageRouter
emitted "Undefined array key 1" warnings for each link while
splitting the pair, causing an exception in development context.

Invalid pairs are now discarded the same way as already done by
RootlineUtility::sanitizeMountPointParameter(), so only pairs
in the format "123-456" are kept.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Georg Ringer uploaded patch set 1 10/02/26, 09:03

  2. Georg Ringer commented on patch set 1 10/02/26, 09:05

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/02/26, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109892

  4. Markus Klein commented on patch set 1 10/02/26, 10:33

    wouldn't it make sense to centralize this sanitization-logic?
  5. Benni Mack commented on patch set 1 CR +1 V +1 10/22/26, 15:44

    Reply

    I think we should centralize most of the mount point logic, but wouldn't start with this patch.
  6. Benni Mack voted on patch set 1 CR +2 V +2 10/23/26, 15:14

  7. Benni Mack merged patch set 2 10/23/26, 15:14