Review main Merged

96304[TASK] Offer copying the generated secret of a webhook

Oli Bartsch CR +2 V +2 Easy +8 −6 updated 10/02/26, 10:31

Commit message

The secret of a webhook is generated into a field that may not be
edited, whose text cannot be selected. As for reactions, the field now
enables the "copyToClipboard" appearance option, so the generated
secret can be copied before the record is saved.

The changelog entry of the option is updated to mention webhooks and
no longer claims every stored password is hashed, as the secret of a
webhook is stored as plain text to sign the requests.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/02/26, 09:57

  2. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/02/26, 10:04

  3. core-ci voted on patch set 1 V +1 10/02/26, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109900

  4. Benni Mack voted on patch set 1 CR +1 V +1 10/02/26, 10:15

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 10/02/26, 10:31

  6. Oli Bartsch merged patch set 2 10/02/26, 10:31