Review main Merged

96305[TASK] Extract additional property path handling

Josua Vogel CR +2 V +2 Normal +145 −24 updated 10/06/26, 06:31

Commit message

The inspector editors of the form editor each write
additionalElementPropertyPaths in their own way, and they treat
doNotSetIfPropertyValueIsEmpty differently.

The TextEditor change handler now delegates to a new helper,
writeAdditionalElementPropertyPaths(), which other editors can reuse.
The helper has no dependency on the form editor's module state and is
covered by the first JavaScript unit test of EXT:form.

Behaviour does not change.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Josua Vogel uploaded patch set 1 10/02/26, 10:33

  2. core-ci voted on patch set 1 V -1 10/02/26, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109906

  3. Josua Vogel uploaded patch set 2 V -1 10/02/26, 10:53

  4. core-ci voted on patch set 2 V +1 10/02/26, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109916

  5. Josua Vogel uploaded patch set 3 V +1 10/02/26, 11:28

  6. core-ci voted on patch set 3 V +1 10/02/26, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109922

  7. Georg Ringer voted on patch set 3 CR +1 V +1 10/02/26, 11:39

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/02/26, 23:04

  9. Georg Ringer voted on patch set 3 CR +2 V +2 10/06/26, 06:31

  10. Georg Ringer merged patch set 4 10/06/26, 06:31